Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seqeralabs/action-tower-launch to v2 #2301

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Update seqeralabs/action-tower-launch to v2 #2301

merged 6 commits into from
Jun 14, 2023

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Jun 6, 2023 •
edited
Loading

  • Updates the Github action to v2
  • Adds specific revision which no longer defaults to github.sha which is a breaking change, hence we update to v2.
  • Saves the JSON log created per pipeline as artifact

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@adamrtalbot
Update seqeralabs/action-tower-launch to v1.2.4
8353340 
- Updates the Github action to v1.2.4
- Adds specific revision which no longer defaults to github.sha
- Saves the JSON log created per pipeline as artifact
@adamrtalbot
Copy link
Contributor Author

Failing test appears to be due to: nextflow-io/nextflow#3989 which has been merged but not released yet.

@codecov
Copy link

codecov bot commented Jun 6, 2023 •
edited
Loading

Codecov Report

Merging #2301 (7029b62) into dev (4639b68) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2301      +/-   ##
==========================================
- Coverage   72.89%   72.84%   -0.06%     
==========================================
  Files          78       78              
  Lines        8756     8745      -11     
==========================================
- Hits         6383     6370      -13     
- Misses       2373     2375       +2

see 10 files with indirect coverage changes

@adamrtalbot adamrtalbot changed the title Update seqeralabs/action-tower-launch to v1.2.4 Update seqeralabs/action-tower-launch to v2 Jun 8, 2023
@adamrtalbot adamrtalbot requested review from mashehu, ewels and maxulysse and removed request for mashehu and ewels June 8, 2023 16:22
@adamrtalbot adamrtalbot merged commit 931b4ee into nf-core:dev Jun 14, 2023
@adamrtalbot adamrtalbot deleted the update_action_tower_launch branch June 14, 2023 11:55
@adamrtalbot adamrtalbot mentioned this pull request Dec 8, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@mashehu mashehu Awaiting requested review from mashehu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse